AIM-47 Move source directory creation to it's own, later stage#145
Merged
AIM-47 Move source directory creation to it's own, later stage#145
Conversation
niquerio
force-pushed
the
try-out-moving-source-dir-generation
branch
from
6947c62 to
7640408
Compare
antmoth
force-pushed
the
try-out-moving-source-dir-generation
branch
from
8de4380 to
894e229
Compare
niquerio
force-pushed
the
try-out-moving-source-dir-generation
branch
from
46e2641 to
5a1d587
Compare
niquerio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses AIM-47
The source directory is a copy of all of the barcode directories within a shipment. It's created as a backup of all the original uncompressed image files.
This PR moves the creation of the source directory out of the Preflight stage and into its own stage which can happen after the non-destructive validation checks like pagination.
The vendor config does not take any destructive steps, so it doesn't need to create the source directory at all. That stage is omitted from the vendor config.